Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an option to enable/disable the binking Nations and Research view buttons #1676

Closed
jwrober opened this issue Jan 1, 2023 · 2 comments · Fixed by #1698
Closed

Create an option to enable/disable the binking Nations and Research view buttons #1676

jwrober opened this issue Jan 1, 2023 · 2 comments · Fixed by #1698
Labels
enhancement New feature or request gui This issue requires changes to the user interface
Milestone
v3.1-stable

Comments

@jwrober
Copy link
Collaborator

jwrober commented Jan 1, 2023

Is your feature request related to a problem? Please describe.
There seems to be some disagreement on the effectiveness of the Nations view and Research view buttons that blink/pulse to remind the player that something needs their attention.

Describe the solution you'd like
In stead of getting rid of it, since it was asked for - simply add some options. One for each to enable/disable the blinking/pulsing. I would suggest they are enabled by default.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Discord - https://discord.com/channels/378908274113904641/912500712833974322/1059195496238940180
@jwrober jwrober added enhancement New feature or request gui This issue requires changes to the user interface labels Jan 1, 2023
@jwrober jwrober added this to the v3.1-stable milestone Jan 1, 2023
@lmoureaux
Copy link
Contributor

I'd rather fix improve UI so as not to use blinking

@lmoureaux
Copy link
Contributor

I suggest changing the icon of the Nations button in the same way as the Messages button changes.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jan 5, 2023
@lmoureaux
Change the Nations button blink to a gentle notification emblem
ce44c09 
This minimizes the annoyance while still hinting that something in the tab is
active.

Closes longturn#1676.
@lmoureaux lmoureaux mentioned this issue Jan 5, 2023
Merged
jwrober pushed a commit that referenced this issue Jan 13, 2023
@lmoureaux @jwrober
Change the Nations button blink to a gentle notification emblem
ed42b1b 
This minimizes the annoyance while still hinting that something in the tab is
active.

Closes #1676.
lmoureaux added a commit that referenced this issue Feb 2, 2023
@lmoureaux
Change the Nations button blink to a gentle notification emblem
91265cc 
This minimizes the annoyance while still hinting that something in the tab is
active.

Closes #1676.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request gui This issue requires changes to the user interface
Projects
None yet
Milestone
v3.1-stable
Development

Successfully merging a pull request may close this issue.

Change the Nations button blink to a gentle notification emblem lmoureaux/freeciv21
2 participants
@lmoureaux @jwrober