Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permit multiple permissions in restrictWithPermissions() #481

Merged
merged 2 commits into from
Jul 12, 2022
Merged

permit multiple permissions in restrictWithPermissions() #481

merged 2 commits into from
Jul 12, 2022

Conversation

paul45
Copy link
Contributor

@paul45 paul45 commented Feb 1, 2022

see #476

src/AuthTrait.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case for the new code. This library needs its workflows updated before Actions will pass.

@paul45
Copy link
Contributor Author

paul45 commented Feb 8, 2022

actualy there are no tests for the AuthTrait.php

@MGatner
Copy link
Collaborator

MGatner commented Apr 27, 2022

I would still like to see a test added; unfortunate that there are no AuthTrait tests but adding one for your code would be a good start. I actually find traits to be easier to test since you can use them on the test case itself then have direct access to all methods.

This will not make it in before #517 so will need rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants