Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsafe loadEnvironment() method in Looker Kotlin SDK #1408

Open
tjbanghart opened this issue Dec 1, 2023 · 0 comments
Open

Remove unsafe loadEnvironment() method in Looker Kotlin SDK #1408

tjbanghart opened this issue Dec 1, 2023 · 0 comments
Labels
enhancement New feature request kotlin Kotlin SDK issues p3 Priority 3

Comments

@tjbanghart
Copy link
Member

Setting global JVM system properties during runtime can be dangerous

As far as I can tell this method is only used by test classes. We should probably move this to a test util class so that we don't expose this within the SDK.
@github-actions github-actions bot added p3 Priority 3 need triage labels Dec 1, 2023
@jeremytchang jeremytchang added enhancement New feature request kotlin Kotlin SDK issues and removed need triage labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature request kotlin Kotlin SDK issues p3 Priority 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tjbanghart @jeremytchang