ensure that default volume preferences apply to new polls (#10907)

* ensure that default volume preferences apply to new polls - change the expectation.. set loud get loud

app/services/discussion_service.rb

@@ -245,7 +245,7 @@ def self.add_users(discussion:, actor:, user_ids:, emails:, audience:)
                            inviter: actor,
                            guest: !volumes.has_key?(user.id),
                            admin: !discussion.group_id,
-                           volume: volumes[user.id] || DiscussionReader.volumes[:normal])
+                           volume: volumes[user.id] || user.default_membership_volume)
     end
 
     DiscussionReader.import(new_discussion_readers, on_duplicate_key_ignore: true)

app/services/poll_service.rb

@@ -142,12 +142,10 @@ def self.create_stances(poll:, actor:, user_ids: [], emails: [], audience: nil,
     volumes = {}
     group_member_ids = (poll.group || NullGroup.new).member_ids
 
-    # if the user has chosen to mute the thread or group then mute the poll too, but dont subsribe
     if poll.discussion_id
       DiscussionReader.active.where(
         discussion_id: poll.discussion_id,
         user_id: users.pluck(:id),
-        volume: 1
       ).find_each do |dr|
         volumes[dr.user_id] = dr.volume
       end
@@ -157,7 +155,6 @@ def self.create_stances(poll:, actor:, user_ids: [], emails: [], audience: nil,
       Membership.active.where(
         group_id: poll.group_id,
         user_id: users.pluck(:id),
-        volume: 1
       ).find_each do |m|
         volumes[m.user_id] = m.volume unless volumes.has_key? m.user_id
       end
@@ -175,7 +172,7 @@ def self.create_stances(poll:, actor:, user_ids: [], emails: [], audience: nil,
         poll: poll,
         inviter: actor,
         guest: !group_member_ids.include?(user.id),
-        volume: volumes[user.id] || DiscussionReader.volumes[:normal],
+        volume: volumes[user.id] || user.default_membership_volume,
         latest: true,
         reason_format: user.default_format,
         created_at: Time.zone.now

spec/services/poll_service_spec.rb

@@ -81,10 +81,10 @@
       expect(Stance.where(participant_id: member.id).first.volume).to eq 'quiet'
     end
 
-    it 'uses normal volume if discussion reader loud' do
+    it 'uses load volume if discussion reader loud' do
       DiscussionReader.create(user_id: member.id, discussion_id: discussion.id, volume: 'loud')
       PollService.create_stances(poll: poll, actor: actor, user_ids: [member.id])
-      expect(Stance.where(participant_id: member.id).first.volume).to eq 'normal'
+      expect(Stance.where(participant_id: member.id).first.volume).to eq 'loud'
     end
 
     it 'uses membership volume if quiet' do