Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multipart/alternative for email encoding #4023

Closed
wants to merge 1 commit into from
Closed

Conversation

gdpelican
Copy link
Contributor

@gdpelican gdpelican commented Apr 13, 2017

I'm not sure why we're using 7bit currently; maybe ahoy email or premailer or something does this?
https://rails-bestpractices.com/posts/2010/08/05/use-multipart-alternative-as-content_type-of-email/

@gdpelican
Copy link
Contributor Author

@robguthrie How do you feel about this change? Ref #4022

@robguthrie
Copy link
Member

I feel fine about the idea, unsure if it will break stuff in practice.
Give it a go?

@fauno
Copy link
Contributor

fauno commented Apr 13, 2017

Content-Type is different from Content-Transfer-Encoding, and every part can have a different CTE. I just checked the parts and the header and text/plain part are CTE 7bit and the text/html part is quoted-printable... while github notifications are all 7bit.

what happens if i use unicode? can you check this notification? áéíóú, 🙃

@fauno
Copy link
Contributor

fauno commented Apr 13, 2017

by looking at the function that throws the error, i'm guessing it's because of the mixed CTEs [7bit,7bit,quoted-printable]: https://github.com/vstakhov/rspamd/blob/71d52e806a4780d95eb0322544330e31a7a375d9/src/libmime/mime_expressions.c#L1277

i also found a github notification where the main cte was 7bit but being written in correct spanish (with tildes and all) the parts were quoted-printable and it was marked as bad_cte_7bit by rspam, so it may be too picky.

@fauno
Copy link
Contributor

fauno commented Apr 13, 2017

asked on rspamd :)

rspamd/rspamd#1590

@gdpelican
Copy link
Contributor Author

Okay, we're not going to go with this for now. Hopefully with the move to SES we won't have these deliverability issues going forward.

@gdpelican gdpelican closed this May 10, 2017
@gdpelican gdpelican deleted the email-encoding branch May 10, 2017 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants