Cleanup and Refactoring #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
commented
Jun 28, 2018
server/contracts/Core/RootChain.sol
Outdated
| * Event for block submission logging | ||
| * @noteice The event indicates the addition of a new Plasma block | ||
| * @param blockNumber The index of the block in which a deposit transaction | ||
| * is included |
There was a problem hiding this comment.
blockNumber: The number of the block that was submitted
gakonst
commented
Jun 28, 2018
server/contracts/Core/RootChain.sol
Outdated
| @@ -185,6 +185,9 @@ contract RootChain is ERC721Receiver { | |||
| smt = new SparseMerkleTree(); | |||
| } | |||
|
|
|||
|
|
|||
| /// @dev called by a Validator to append a Plamsa block to the Plasma chain | |||
Closed
setChallenged is only called once and should be removed to make the contract shorter & easier to read.
- setChallenged exists as a separate function becuase of stack limit errors - changing getExitIndex function to return an impossible exit value in case a particular slot's exit is not found
…rc721 into cleanup-from-master
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #70 but without the messy rebase/fast forward