Refactored Address to not be a partial class of Protobuf Address class #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! Did you test |
|
I didn't. What's specific about it for WebGL?
…On Sat, Jun 23, 2018, 18:56 Vadim Macagon ***@***.***> wrote:
Very nice! Did you test AddressJsonConverter in WebGL?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA4rJr3mFDvKWmXphSpCsm6ixmNvA1t9ks5t_nMygaJpZM4U02O9>
.
|
|
Just the usual WebGL issues that crop up when symbols are stripped during the build. This looks safe enough though I suppose. |
|
@enlight Ah. It's not just WebGL then, also iOS, and, optionally, Android and Desktop. But yes, this should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresswas the only Protobuf class from the SDK that was supposed to be used by end-users. Generally, this should not happen - Protobuf stuff is too low-level, and there's a reason why Protobuf classes aresealed- they are not supposed to be extended in any way. It was also quite annoying to see Protobuf-related methods in autocomplete when working with addresses.This PR basically adds a nicer
Addressstruct and hides all Protobuf stuff away from end users' eyes.Noteworthy:
Addressdirectly when encoding/decoding EVM data with Nethereum, instead of using plain strings. It is currently quite annoying to juggle betweenAddressand purestringrepresentations of the same thing. This will make the usage patterns more uniform.Addressinstances can now be compared using==and!=operators for convenience.struct.Debug.Log(address);now actually logs the address string