refactor(core): Component servers are now key-value pairs

BREAKING CHANGE: Components must now provide key-value pairs in an object called "servers".
loopbackio · Sep 29, 2017 · 866953a · 866953a
1 parent b0e5360
commit 866953a
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 7 deletions.
diff --git a/packages/core/src/component.ts b/packages/core/src/component.ts
@@ -14,7 +14,9 @@ export interface Component {
   // tslint:disable-next-line:no-any
   controllers?: Constructor<any>[];
   providers?: ProviderMap;
-  servers?: Constructor<Server>[];
+  servers?: {
+    [name: string]: Constructor<Server>;
+  };
 
   // tslint:disable-next-line:no-any
   [prop: string]: any;
@@ -41,8 +43,8 @@ export function mountComponent(app: Application, component: Component) {
   }
 
   if (component.servers) {
-    for (const server of component.servers) {
-      app.server(server);
+    for (const serverKey in component.servers) {
+      app.server(component.servers[serverKey], serverKey);
     }
   }
 }
diff --git a/packages/core/test/unit/application.test.ts b/packages/core/test/unit/application.test.ts
@@ -65,9 +65,14 @@ describe('Application', () => {
 });
 
 class FakeComponent implements Component {
-  servers: Constructor<Server>[] = [];
+  servers: {
+    [name: string]: Constructor<Server>;
+  };
   constructor() {
-    this.servers.push(FakeServer);
+    this.servers = {
+      FakeServer,
+      FakeServer2: FakeServer,
+    };
   }
 }
 

diff --git a/packages/rest/src/rest-component.ts b/packages/rest/src/rest-component.ts
@@ -43,13 +43,18 @@ export class RestComponent implements Component {
     [RestBindings.SequenceActions.PARSE_PARAMS]: ParseParamsProvider,
     [RestBindings.SequenceActions.SEND]: SendProvider,
   };
-  servers: Constructor<Server>[] = [];
+  servers: {
+    [name: string]: Constructor<Server>;
+  };
+
   constructor(
     @inject(CoreBindings.APPLICATION_INSTANCE) app: Application,
     @inject(RestBindings.CONFIG) config?: RestComponentConfig,
   ) {
     if (!config) config = {};
-    this.servers.push(RestServer);
+    this.servers = {
+      RestServer: RestServer,
+    };
   }
 }