Loophole doesn't reconnect after a network outage

[jarble]

My wireless network connection is occasionally disrupted. Whenever this happens, Loophole attempts to reconnect 5 times and then quits.

Instead of quitting when the network goes down, should Loophole stay open and attempt to reconnect when the network is available again?

[0x7f]

Hi @jarble we have a hard-coded retry count here:

cli/internal/app/loophole/loophole.go

Lines 102 to 120 in 06767ef

	var sshRetries int = 5
	var err error
	for i := 0; i < sshRetries && !sshSuccess; i++ { // Connection retries in case of reconnect during gateway shutdown
	communication.LoadingStart(tunnelID, "Initializing secure tunnel... ")
	serverSSHConnHTTPS, err = ssh.Dial("tcp", config.Config.GatewayEndpoint.Hostname(), sshConfigHTTPS)
	if err != nil {
	communication.LoadingFailure(tunnelID, err)
	communication.TunnelInfo(tunnelID, fmt.Sprintf("SSH Connection failed, retrying in 10 seconds... (Attempt %d/%d)", i+1, sshRetries))
	time.Sleep(10 * time.Second)
	} else {
	sshSuccess = true
	}
	}
	if !sshSuccess {
	communication.TunnelError(tunnelID, "An error occured while dialing into SSH. If your connection has been running for a while, "+
	"this might be caused by the server shutting down your connection. Dialing SSH Gateway for HTTPS failed.")
	err = fmt.Errorf("failed %d", 5)
	return nil, err
	}

We could either always make it retry forever, or make the retry configurable via cli argument. @Morishiri what would you prefer?

[Morishiri]

let's make it configurable via cli, with 0 being infinity

[jarble]

@Morishiri and @0x7f If this becomes configurable, should it be "infinity" by default?

[xfearx1]

Hello, will this be a thing?
My network is also a little unstable, and sometimes it disconnects in the middle of the night, then for me find out just in the morning it was down for several hours.