Use phpstan/phpstan-strict-rules.

loophp · Aug 12, 2019 · 83a4e4d · 83a4e4d
1 parent 7247de4
commit 83a4e4d
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 17 deletions.
diff --git a/composer.json b/composer.json
@@ -25,6 +25,7 @@
         "infection/infection": "^0.13",
         "phpspec/phpspec": "^5",
         "phpstan/phpstan": "^0.11",
+        "phpstan/phpstan-strict-rules": "^0.11.1",
         "scrutinizer/ocular": "^1.6"
     },
     "config": {

diff --git a/src/Collection.php b/src/Collection.php
@@ -354,11 +354,7 @@ public function walk(callable ...$callbacks): CollectionInterface
     }
 
     /**
-     * Create a new collection instance.
-     *
-     * @param null|array|callable|Closure|CollectionInterface $data
-     *
-     * @return \drupol\collection\Contract\Collection
+     * {@inheritdoc}
      */
     public static function with($data = []): CollectionInterface
     {
@@ -370,9 +366,7 @@ public static function with($data = []): CollectionInterface
     }
 
     /**
-     * @param array $array
-     *
-     * @return \drupol\collection\Contract\Collection
+     * {@inheritdoc}
      */
     public static function withArray(array $array): CollectionInterface
     {
@@ -386,11 +380,7 @@ public static function withArray(array $array): CollectionInterface
     }
 
     /**
-     * Create a new collection instance.
-     *
-     * @param callable $callback
-     *
-     * @return \drupol\collection\Contract\Collection
+     * {@inheritdoc}
      */
     public static function withClosure(callable $callback): CollectionInterface
     {

diff --git a/src/Contract/Collection.php b/src/Contract/Collection.php
@@ -4,6 +4,8 @@
 
 namespace drupol\collection\Contract;
 
+use Closure;
+
 /**
  * Interface Collection.
  */
@@ -185,6 +187,16 @@ public function nth(int $step, int $offset = 0): self;
      */
     public function only(...$keys): self;
 
+    /**
+     * TODO: Pad.
+     *
+     * @param int $size
+     * @param mixed $value
+     *
+     * @return \drupol\collection\Contract\Collection
+     */
+    public function pad(int $size, $value): self;
+
     /**
      * Push an item onto the beginning of the collection.
      *
@@ -238,7 +250,9 @@ public function slice(int $offset, int $length = null): self;
     public function walk(callable ...$callbacks): self;
 
     /**
-     * @param mixed $data
+     * Create a new collection instance.
+     *
+     * @param null|array|callable|Closure|Collection $data
      *
      * @return \drupol\collection\Contract\Collection
      */
@@ -252,6 +266,8 @@ public static function with($data = []): self;
     public static function withArray(array $data): self;
 
     /**
+     * Create a new collection instance.
+     *
      * @param callable $callable
      *
      * @return \drupol\collection\Contract\Collection

diff --git a/src/Operation/Flatten.php b/src/Operation/Flatten.php
@@ -30,8 +30,8 @@ static function () use ($depth, $collection) {
                             yield $i;
                         }
                     } else {
-                        foreach ($collection::with($item)->flatten($depth - 1) as $item) {
-                            yield $item;
+                        foreach ($collection::with($item)->flatten($depth - 1) as $flattenItem) {
+                            yield $flattenItem;
                         }
                     }
                 }

diff --git a/src/Operation/Limit.php b/src/Operation/Limit.php
@@ -22,7 +22,7 @@ public function run(Collection $collection): Collection
             static function () use ($limit, $collection) {
                 $iterator = $collection->getIterator();
 
-                for (; $iterator->valid() && $limit--; $iterator->next()) {
+                for (; (true === $iterator->valid()) && (0 !== $limit--); $iterator->next()) {
                     yield $iterator->key() => $iterator->current();
                 }
             }