Static Analysis Checks: Common Operations (II)

[AlexandruGG]

This PR adds more static analysis checks for commonly-used methods, and fixes a few type hints in the process.

• filter
• first
• head
• last

[AlexandruGG]

I feel like it's a bit inconsistent with the others that filter works like this. I was expecting multiple callbacks to behave like logical OR

[AlexandruGG]

@drupol what do you think?

[drupol]

Yep, this is one of the gotcha(s) I couldn't fix in a lazy way.

[AlexandruGG]

I see, no worries I've updated the docs and example 😁

[AlexandruGG]

Weird, looks like unit tests on windows on php 8 sometimes get stuck taking forever. Saw it happen once previously but I cannot cancel the job 🤷‍♂️. 10 min and still going

[drupol]

Hello,
Most of the things are great, I just added a minor remark.
Let me know what you think.

[drupol]

By removing this, you get 2 new minor errors in PSalm:

 ~/d/g/collection   feature/more-static-analysis-checks $…  ./vendor/bin/psalm --show-info=true src/Operation/First.php                                            
Scanning files...
Analyzing files...

░

INFO: MixedReturnTypeCoercion - src/Operation/First.php:23:16 - The declared return type 'Closure(Iterator<TKey:loophp\collection\Operation\First as mixed, T:loophp\collection\Operation\First as mixed>):Generator<TKey:loophp\collection\Operation\First as mixed, T:loophp\collection\Operation\First as mixed, mixed, mixed>' for loophp\collection\Operation\First::__invoke is more specific than the inferred return type 'Closure' (see https://psalm.dev/197)
     * @return Closure(Iterator<TKey, T>): Generator<TKey, T>


INFO: MixedReturnTypeCoercion - src/Operation/First.php:27:16 - The type 'Closure' is more general than the declared return type 'Closure(Iterator<TKey:loophp\collection\Operation\First as mixed, T:loophp\collection\Operation\First as mixed>):Generator<TKey:loophp\collection\Operation\First as mixed, T:loophp\collection\Operation\First as mixed, mixed, mixed>' for loophp\collection\Operation\First::__invoke (see https://psalm.dev/197)
        return Head::of();


------------------------------
No errors found!
------------------------------
2 other issues found.
------------------------------

Checks took 0.54 seconds and used 235.298MB of memory
Psalm was able to infer types for 100% of the codebase
 ~/d/g/collection   feature/more-static-analysis-checks $

[AlexandruGG]

oooh I didn't notice those, I guess because of the info level. I'll see if I can fix those, if not I'll revert

[AlexandruGG]

@drupol I see now why it happens, it's because AbstractOperation::of has the simple return type Closure. I think this makes sense as they are not all the same.

I don't think it should be a problem because it's just an info thing, but I've reverted this change to keep the same style as others

[AlexandruGG]

thanks!

[drupol]

Thanks you!!!