Static Analysis Checks: Common Operations (III) #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandruGG
commented
Jun 21, 2021
Comment on lines
+442
to
446
| /** | ||
| * @param TKey $key | ||
| * @param T|null $default | ||
| */ | ||
| public function get($key, $default = null): CollectionInterface |
There was a problem hiding this comment.
the @param T|null $default annotation is needed here because otherwise Psalm interprets $default as type T and T as null because of the default null value.
Because of that it thinks that Collection::fromIterable([1, 2, 3])->get(1) is always Collection<int, null> instead of Collection<int, int|null>
|
All good :) Thanks ! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more static analysis checks for commonly-used methods, and fixes a few type hints in the process.
Follows #109.