Fix/update PHPStan #212
Fix/update PHPStan #212
Conversation
|
Hey, for this:
Looks like all the failures are related to ignored errors which are actually not found in the code on 7.4. To silence those errors we could just use this config option |
drupol
force-pushed
the
fix/update-phpstan
branch
from
8041ab8
to
dcd6403
Compare
phpstan-baseline.neon
Outdated
| message: "#^Parameter \\#1 \\$callable of class loophp\\\\collection\\\\Iterator\\\\ClosureIterator constructor expects callable\\(\\.\\.\\.mixed\\)\\: iterable, Closure\\(Generator\\)\\: Generator\\<mixed, mixed, mixed, void\\> given\\.$#" | ||
| count: 1 | ||
| path: src/Collection.php | ||
|
|
There was a problem hiding this comment.
@drupol I'm a bit concerned by the high number of new errors this is adding to the baseline. This is likely due to PHPStan's new level 9, which is quite brutal, similar to Psalm's level 1 which disallows mixed (which we are not using - this this project uses the default Psalm level 2).
This PR is currently trying to do 2 things at the same time, and I think we should separate them:
-
updating to PHPStan 1.0 -> we should be able to do this and fix any errors as long as there aren't too many
-
updating to PHPStan level 9 -> I don't think we can do this yet, it might take quite a bit of work to get the static analysis in place properly for this. For now I think we should limit the level to 8 in the grumphp config for this project only
There was a problem hiding this comment.
Right, I had this in mind as well at the beginning, then I skipped it.
I will update the PR accordingly in the evening.
drupol
force-pushed
the
fix/update-phpstan
branch
from
dcd6403
to
7b18dd9
Compare
| message: "#^PHPDoc tag @template T for class loophp\\\\collection\\\\Contract\\\\Operation\\\\Unpackable with bound type array\\<int, NewT\\|NewTKey\\> is not supported\\.$#" | ||
| count: 1 | ||
| path: src/Contract/Operation/Unpackable.php | ||
|
|
||
| - | ||
| message: "#^PHPDoc tag @template T for interface loophp\\\\collection\\\\Contract\\\\Operation\\\\Unpackable with bound type array\\<int, NewT\\|NewTKey\\> is not supported\\.$#" | ||
| count: 1 | ||
| path: src/Contract/Operation/Unpackable.php | ||
|
|
||
| - | ||
| message: "#^PHPDoc tag @template T for class loophp\\\\collection\\\\Operation\\\\Unpack with bound type array\\<int, NewT\\|NewTKey\\> is not supported\\.$#" | ||
| count: 1 | ||
| path: src/Operation/Unpack.php |
There was a problem hiding this comment.
something good came out of this 😄
This PR:
reportUnmatchedIgnoredErrorsFixes #210