[PHPStan Baseline] Fix a few errors #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandruGG
commented
Nov 9, 2021
Comment on lines
-362
to
+359
| * @return self<NewTKey, NewT> | ||
| * @return self<mixed, mixed> |
There was a problem hiding this comment.
these template types cannot be inferred from anywhere, so the better option here is to just use mixed
AlexandruGG
commented
Nov 9, 2021
| @@ -212,6 +212,7 @@ | |||
| * @template-extends Prependable<TKey, T> | |||
| * @template-extends Productable<TKey, T> | |||
| * @template-extends Randomable<TKey, T> | |||
| * @template-extends Rangeable<TKey, T> | |||
There was a problem hiding this comment.
somehow this was missing 😄
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| namespace loophp\collection\Contract\Operation; | |||
|
|
|||
| use Closure; | |||
There was a problem hiding this comment.
found a couple of these where the import was missing but the Closure was mentioned in the doc blocks. Because of the missing import PHPStan couldn't resolve the type
AlexandruGG
changed the title
drupol
approved these changes
Nov 9, 2021
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| namespace loophp\collection\Contract\Operation; | |||
|
|
|||
| use Closure; | |||
Thanks 😁 . I'll merge this once the checks have finished |
|
Thanks !! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Follows #212