Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code example in README #3

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Fix code example in README #3

merged 1 commit into from
Jan 16, 2021

Conversation

jdreesen
Copy link
Contributor

This PR

  • Fixed the code example in the readme.

@jdreesen jdreesen requested a review from drupol as a code owner January 16, 2021 21:53
@drupol
Copy link
Collaborator

drupol commented Jan 16, 2021

Hi mate,

Thanks for your contribution (all of them), unfortunately, I have to decline this one. The README is good as it is and it's working perfectly well, there is no need to make that change.

@jdreesen
Copy link
Contributor Author

No, it isn't. At least there's a syntax error in lines 60/61: https://3v4l.org/flYbb

Apart from that, the generator yields three values while the sprintf calls in lines 64/65 expect only two parameters: the result and the duration (in that order).

@drupol
Copy link
Collaborator

drupol commented Jan 16, 2021

Oh indeed, you're perfectly right ! Sorry about that.

@drupol drupol merged commit 790a0c3 into loophp:master Jan 16, 2021
@drupol
Copy link
Collaborator

drupol commented Jan 16, 2021

Thanks !!!

@jdreesen jdreesen deleted the patch-1 branch January 16, 2021 22:22
@drupol
Copy link
Collaborator

drupol commented Jan 16, 2021

I updated the README again, the code example was misleading, it's now better!

@jdreesen
Copy link
Contributor Author

jdreesen commented Jan 16, 2021

But now it isn't using the fibonacci function anymore... see: e56d672#r46031564

@drupol
Copy link
Collaborator

drupol commented Jan 16, 2021

Looks like I'm working too late, I'll fix this tomorrow! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants