Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design question: New* functions #8

Closed
JensRantil opened this issue Nov 30, 2014 · 2 comments
Closed

Design question: New* functions #8

JensRantil opened this issue Nov 30, 2014 · 2 comments

Comments

@JensRantil
Copy link
Contributor

When I went over error handling I noticed that there is no error handling in the New* functions. Wouldn't it a good idea to validate input as early as possible?
@maxekman
Copy link
Member

Absolutely! I was going to add that but haven't had time yet. If you feel for it you are welcome to give it a go.

JensRantil added a commit to JensRantil/eventhorizon that referenced this issue Dec 1, 2014
@JensRantil
fix(typo): ErrNotEventsFound => ErrNoEventsFound
314eb19 
Discussed this with @maxpersson in looplab#8.
JensRantil added a commit to JensRantil/eventhorizon that referenced this issue Dec 1, 2014
@JensRantil
fix: rename NoEventStoreDefinedError to ErrNoEventStoreDefined
57726ca 
Discussed this with @maxpersson in looplab#8.
@JensRantil
Copy link
Contributor Author

I revisited the code and couldn't find the specific functions I had in mind. :) My apologies. Should have written that in the origin issue description... I'll be closing this. Feel free to reopen if you have a function in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JensRantil @maxekman