refactor RadioLib Task, change beacon config, fix aprs-is filter printout

.github/workflows/build_check.yml

@@ -79,7 +79,26 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v3
       - name: Run PlatformIO Check
-        run: pio check --fail-on-defect high -e lora_board
+        run: pio check --fail-on-defect high --fail-on-defect medium --fail-on-defect low -e lora_board
+
+  cppcheck-docker:
+    name: Run cppcheck in Docker
+    runs-on: ubuntu-latest
+    env:
+      CPPCHECK_ARGS: --enable=all --std=c++20 --inline-suppr -I lib/BoardFinder -I lib/ConfigurationManagement -I lib/Display -I lib/LoRa -I lib/LoRa_APRS -I lib/NTPClient -I lib/PowerManagement -I lib/System -I lib/TimeLib -i lib/Display -i lib/LoRa -i lib/NTPClient -i lib/TimeLib src lib
+    steps:
+      - name: checkout code
+        uses: actions/checkout@v3
+      - run: docker pull facthunder/cppcheck:latest
+      - name: Run cppcheck and print result
+        run: docker run --rm -v ${PWD}:/src facthunder/cppcheck:latest /bin/bash -c "cppcheck $CPPCHECK_ARGS"
+      - name: Run cppcheck and create html
+        run: docker run --rm -v ${PWD}:/src facthunder/cppcheck:latest /bin/bash -c "cppcheck --xml $CPPCHECK_ARGS 2> report.xml && cppcheck-htmlreport --file=report.xml --report-dir=output"
+      - name: Upload report
+        uses: actions/upload-artifact@v3
+        with:
+          name: Cppcheck Report
+          path: output
 
   hw_testing:
     name: Hardware Testing

data/is-cfg.json

@@ -30,7 +30,8 @@
 			"longitude": 0.000000
 		},
 		"use_gps": false,
-		"timeout": 15
+		"timeout": 15,
+		"send_on_hf": false
 	},
 	"aprs_is": {
 		"active": true,
@@ -40,8 +41,7 @@
 		"filter": ""
 	},
 	"digi": {
-		"active": false,
-		"beacon": false
+		"active": false
 	},
 	"lora": {
 		"frequency_rx": 433775000,

lib/PowerManagement/power_management.cpp

@@ -1,7 +1,7 @@
 
 #include "power_management.h"
 
-PowerManagement::PowerManagement() {
+PowerManagement::PowerManagement() : axp() {
 }
 
 bool PowerManagement::begin(TwoWire &port) {

platformio.ini

@@ -16,10 +16,10 @@ lib_deps =
 	knolleary/PubSubClient@^2.8
 	mikalhart/TinyGPSPlus @ 1.0.3
 	shaggydog/OneButton @ 1.5.0
-	jgromes/RadioLib @ 5.7.0
+	jgromes/RadioLib @ 6.0.0
 check_tool = cppcheck
 check_flags =
-	cppcheck: --std=c++14 --suppress=*:*.pio\* --inline-suppr --suppress=unusedFunction -DCPPCHECK --force lib -ilib/TimeLib
+	cppcheck: --std=c++20 --suppress=*:*.pio\* --inline-suppr --suppress=unusedFunction -DCPPCHECK --force lib -ilib/TimeLib
 check_skip_packages = yes
 test_build_src = yes
 # activate for OTA Update, use the CALLSIGN from is-cfg.json as upload_port:

src/TaskAprsIs.cpp

@@ -30,9 +30,11 @@ bool AprsIsTask::loop(System &system) {
     return false;
   }
 
-  std::shared_ptr<APRSMessage> msg = _aprs_is.getAPRSMessage();
-  if (msg) {
-    _toModem.addElement(msg);
+  {
+    std::shared_ptr<APRSMessage> msg = _aprs_is.getAPRSMessage();
+    if (msg) {
+      _toModem.addElement(msg);
+    }
   }
 
   if (!_toAprsIs.empty()) {
@@ -44,7 +46,7 @@ bool AprsIsTask::loop(System &system) {
 }
 
 bool AprsIsTask::connect(System &system) {
-  system.getLogger().log(logging::LoggerLevel::LOGGER_LEVEL_INFO, getName(), "connecting to APRS-IS server: %s on port: %d, with filter: '%s'", system.getUserConfig()->aprs_is.server.c_str(), system.getUserConfig()->aprs_is.port, system.getUserConfig()->aprs_is.filter);
+  system.getLogger().log(logging::LoggerLevel::LOGGER_LEVEL_INFO, getName(), "connecting to APRS-IS server: %s on port: %d, with filter: '%s'", system.getUserConfig()->aprs_is.server.c_str(), system.getUserConfig()->aprs_is.port, system.getUserConfig()->aprs_is.filter.c_str());
   APRS_IS::ConnectionStatus status = APRS_IS::ConnectionStatus::ERROR_CONNECTION;
   if (system.getUserConfig()->aprs_is.filter.isEmpty()) {
     status = _aprs_is.connect(system.getUserConfig()->aprs_is.server, system.getUserConfig()->aprs_is.port);

src/TaskBeacon.cpp

@@ -116,7 +116,7 @@ bool BeaconTask::sendBeacon(System &system) {
     _toAprsIs.addElement(_beaconMsg);
   }
 
-  if (system.getUserConfig()->digi.beacon) {
+  if (system.getUserConfig()->beacon.send_on_hf) {
     _toModem.addElement(_beaconMsg);
   }
 

src/TaskMQTT.h

@@ -8,7 +8,7 @@
 
 class MQTTTask : public Task {
 public:
-  MQTTTask(TaskQueue<std::shared_ptr<APRSMessage>> &toMQTT);
+  explicit MQTTTask(TaskQueue<std::shared_ptr<APRSMessage>> &toMQTT);
   virtual ~MQTTTask();
 
   virtual bool setup(System &system) override;