Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define show_debug as an option and update readme with instructions. #15

Merged
merged 2 commits into from
Jul 30, 2015
Merged

Define show_debug as an option and update readme with instructions. #15

merged 2 commits into from
Jul 30, 2015

Conversation

mcavallo
Copy link
Collaborator

No description provided.

@lord
Copy link
Owner

lord commented Jul 29, 2015

Awesome! Let me take a look...

Also thanks to [Mariano](https://github.com/mcavallo), who contributed a significant chunk of code to get $_GET, $_POST, and other PHP global request variables working.
```ruby
activate :php do |config|
config.show_debug = true # Output debug info to console
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I've looked at this so maybe I'm just reading it incorrectly, but isn't this false by default, not true?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, It's a typo on the readme. I will correct it.

mcavallo added a commit that referenced this pull request Jul 30, 2015
Define show_debug as an option and update readme with instructions.
@mcavallo mcavallo merged commit d840785 into lord:master Jul 30, 2015
@lord
Copy link
Owner

lord commented Jul 30, 2015

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants