Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stSearch Documentation Correction #35

Closed
kenhowardpdx opened this issue Jun 3, 2015 · 2 comments
Closed

stSearch Documentation Correction #35

kenhowardpdx opened this issue Jun 3, 2015 · 2 comments

Comments

@kenhowardpdx
Copy link

In various places in the documentation it appears that the value of st-search is a string. But in reality it should be an expression that evaluates to a string.

I would update the documentation and submit a PR, but the documentation is missing.

Example:

Change this:
<input st-search="firstName" placeholder="search for firstname" class="input-sm form-control" type="search"/>

to this:
<input st-search="'firstName'" placeholder="search for firstname" class="input-sm form-control" type="search"/>

subtle change. Added single-quotes around the firstName key.

@lorenzofox3
Copy link
Owner

I don't think it is true, what is the version you are using ?
Refere to the change log (v2.0..0)

@kenhowardpdx
Copy link
Author

@lorenzofox3 Good point. I'm using 1.4.13 😄 Not going to upgrade though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants