Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan to release to CRAN? #49

Closed
maelle opened this issue Nov 27, 2019 · 5 comments
Closed

plan to release to CRAN? #49

maelle opened this issue Nov 27, 2019 · 5 comments
Labels
Complexity: High Priority: Critical Status: WIP Type: Meta
Milestone
v0.0.1

Comments

@maelle
Copy link
Contributor

maelle commented Nov 27, 2019

👋 here, do you plan to release precommit to CRAN soon? Thanks. :-)
@lorenzwalthert
Copy link
Owner

Good idea :-) Yes I think I should do it before the end of the year. I must disable all tests that require python / conda though.

@lorenzwalthert lorenzwalthert mentioned this issue Nov 27, 2019
Merged
@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Nov 27, 2019 •
edited
Loading

@maelle if I put it on CRAN for you can you please do me a favour and quickly do a full ropensci review 😃. No honestly, if there is anything missing or could be improved without much work, I am happy to hear your feedback.

@maelle maelle mentioned this issue Nov 28, 2019
Closed
@lorenzwalthert
Copy link
Owner

I might not able to hold the promise as macOS Catalina is giving us some problems due to changed default installation path that reticulate can't easily find (rstudio/reticulate#661). I think we should wait until this is resolved in the next CRAN version. I don't want people to have a headache when they first use a package fresh brought to CRAN.

@dfrankow dfrankow mentioned this issue Feb 24, 2020
Closed
@lorenzwalthert lorenzwalthert added this to the v0.0.1 milestone Apr 6, 2020
@lorenzwalthert
Copy link
Owner

@krzyslom Thanks for your contributions to {precommit}. I plan to submit this to CRAN soon, so I just wanted to ask you how many more issues you think you want to open before that? I value your contributions and want to make sure we don't miss something important for v0.1.0.

@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Jun 14, 2020 •
edited
Loading

Closed with https://twitter.com/lorenzwalthert/status/1271866865279787008 🎉 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: High Priority: Critical Status: WIP Type: Meta
Projects
None yet
Milestone
v0.0.1
Development

No branches or pull requests
2 participants
@maelle @lorenzwalthert