-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the default export breaks the public API without a major update #100
Comments
👍 |
1 similar comment
+1 |
ptal @ZauberNerd @TrySound @KingHenne https://github.com/meandmax/lory/tree/revert-babel6 I have not thought about that this is actually a breaking change, sorry ;-) ... For the reason that Babel6 is currently a big mess I made a step back to good old Babel5 and also pinned down all other dependencies to their fixed versions. Have a nice weekend! |
@meandmax What's wrong with babel6? |
@TrySound I will wait until the Babel6 fixing flood is over. At least I need a solution that will not break the UMD wrapper and will work as a default in all common js environments. |
As I discussed with @ZauberNerd and a couple of other lory users, we will keep the changes with Babel6 and for the future I will be more careful with breaking changes. Have a nice weekend! |
The change in 95aa9d4 is a breaking change but does not increase the major version of this package.
see: 95aa9d4#commitcomment-14328452
The text was updated successfully, but these errors were encountered: