Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the default export breaks the public API without a major update #100

Closed
ZauberNerd opened this issue Nov 11, 2015 · 7 comments
Closed

Comments

@ZauberNerd
Copy link
Contributor

The change in 95aa9d4 is a breaking change but does not increase the major version of this package.
see: 95aa9d4#commitcomment-14328452

@TrySound
Copy link
Contributor

👍

1 similar comment
@unstubbable
Copy link
Contributor

+1

@meandmax
Copy link
Collaborator

ptal @ZauberNerd @TrySound @KingHenne

https://github.com/meandmax/lory/tree/revert-babel6

I have not thought about that this is actually a breaking change, sorry ;-) ...

For the reason that Babel6 is currently a big mess I made a step back to good old Babel5 and also pinned down all other dependencies to their fixed versions.

Have a nice weekend!
Max

@TrySound
Copy link
Contributor

@meandmax What's wrong with babel6?

@meandmax
Copy link
Collaborator

@TrySound I will wait until the Babel6 fixing flood is over. At least I need a solution that will not break the UMD wrapper and will work as a default in all common js environments.

@TrySound
Copy link
Contributor

@meandmax Try rollup. Much smaller then webpack loader. Supports any output format

@meandmax
Copy link
Collaborator

As I discussed with @ZauberNerd and a couple of other lory users, we will keep the changes with Babel6 and for the future I will be more careful with breaking changes.

Have a nice weekend!
Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants