Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming requests for Net::HTTP #461

Closed
wants to merge 1 commit into from
Closed

Conversation

@grosser
Copy link
Contributor

grosser commented Sep 11, 2015

can you fix up the build ?

@mislav any ❤️ for this ? :)

@grosser
Copy link
Contributor

grosser commented Sep 11, 2015

only error I can reproduce locally is:

  1) Failure:
Adapters::NetHttpTest#test_GET_streaming [/Users/mgrosser/Code/tools/faraday/test/adapters/integration.rb:349]:
--- expected
+++ actual
@@ -1 +1 @@
-" !\"\#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~ !\"\#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~ !\"\#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`a"
+""

rest might be fixable by rebasing ...

@mislav
Copy link
Contributor

mislav commented Sep 11, 2015

This looks pretty impressive. Sorry for no review. @grosser you're welcome to try to rebase this branch against current master if @jcoyne isn't able to do it.

@grosser
Copy link
Contributor

grosser commented Sep 12, 2015

any idea how to run this 1 failing test ... rake passes locally when rebased and I did not find a way to execute just 1 test ... via -n or similar :(

@jcoyne
Copy link
Author

jcoyne commented Sep 14, 2015

I don't foresee having any time to work on this in the near future. All I did was to rebase the work done by others.

@nightscape
Copy link
Contributor

@jcoyne I've created a rebased version of this PR in #604 that also fixes the issue mentioned by @grosser.
Can you close this PR in favor of the above one?

@iMacTia
Copy link
Member

iMacTia commented Aug 31, 2016

Closing in favour of #604

@iMacTia iMacTia closed this Aug 31, 2016
@jcoyne
Copy link
Author

jcoyne commented Aug 31, 2016

@nightscape Thanks for picking this up. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants