Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: RuboCop lint Style/MultilineTernaryOperator #913

Merged
merged 3 commits into from Mar 3, 2019

Conversation

olleolleolle
Copy link
Member

Description

This PR lints a file with complex code.

The rule Style/MultilineTernaryOperator is now all fixed.

Details

I fixed the rule. Then, with that fix, there were follow-on issues. I took them on, too.

I was much helped by the Workflow described in the #854 - thanks @iMacTia for adding that.

@olleolleolle olleolleolle mentioned this pull request Mar 3, 2019
Copy link
Member Author

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix that thing I noted.

.rubocop_todo.yml Outdated Show resolved Hide resolved
.rubocop_todo.yml Show resolved Hide resolved
@olleolleolle
Copy link
Member Author

@iMacTia In order to verify that I'd got rid of the new sorts of issues, I regenerated the TODO.

@iMacTia iMacTia merged commit 1c0f43b into master Mar 3, 2019
@iMacTia iMacTia deleted the fix/rubocop-multiline branch March 3, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants