-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuboCop Quest Issue #854
Comments
Removing this comment. My previous assertion was wrong. Future devs should note that .rubocop_todo.yml file when checking for violations. |
I checked off |
I hadn't seen this post before I fixed the |
Thanks, everyone! 🚀 |
Basic Info
We are linting the whole codebase using RuboCop.
This is a list of all the rules in the
.rubocop_todo.yml
when we started. The checkmarks mean "this is fixed and merged to master".If you create a PR to fix one of these, use the
--only
option in RuboCop, to focus the effort on 1 kind of fix. It's so easy to get overwhelmed when reviewing code like this. (If you fix slightly more than that, no biggie. This is all about keeping the changes reviewable.)A workflow
Issue description
Metrics/AbcSizeMetrics/ClassLength chore: rubocop lint Metrics/ClassLength #944Metrics/CyclomaticComplexityMetrics/MethodLengthMetrics/ModuleLengthMetrics/PerceivedComplexityStyle/ClassVars
#902Style/ClassVars
#902Style/ClassVars
#902Style/ClassVars
#902The text was updated successfully, but these errors were encountered: