Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuboCop rule: Allow !! #922

Merged
merged 2 commits into from Mar 3, 2019
Merged

RuboCop rule: Allow !! #922

merged 2 commits into from Mar 3, 2019

Conversation

olleolleolle
Copy link
Member

Description

This PR configures RuboCop to allow the double negation expression !!something.

Many difficult spots where the alternative code becomes less readable.

iMacTia
iMacTia reviewed Mar 3, 2019
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this change be reflected on the .rubocop_todo.yml file? I guess if you run --auto-gen-config will remove the 9 offences listed there?

@olleolleolle olleolleolle mentioned this pull request Mar 3, 2019
Closed
@olleolleolle olleolleolle merged commit c209c41 into master Mar 3, 2019
@olleolleolle olleolleolle deleted the allow-the-doublenegation branch March 3, 2019 22:27
@htwroclau htwroclau mentioned this pull request Mar 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olleolleolle @iMacTia