Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let rashify inherit from mashify #16

Merged
merged 1 commit into from
Sep 26, 2011
Merged

let rashify inherit from mashify #16

merged 1 commit into from
Sep 26, 2011

Conversation

stve
Copy link
Contributor

@stve stve commented Sep 26, 2011

I was looking at Mashify and Rashify and realized their parse methods were identical. Since Response::Mashify allows assignment of the mash_class, we can simple inherit from Mashify and assign the mash_class appropriately. All tests still pass with 1.8.7 and 1.9.2

sferik added a commit that referenced this pull request Sep 26, 2011
@sferik
Merge pull request #16 from spagalloco/simplify_rashify
734ae7b 
let rashify inherit from mashify
@sferik sferik merged commit 734ae7b into lostisland:master Sep 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stve @sferik