-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subclass errors from a general Lotus module error #82
Conversation
@liamdawson Hello, and thanks for this contribution. Can you please name it |
module Lotus | ||
module View | ||
class ViewError < ::StandardError | ||
def intialize(message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add that constructor
@jodosha and @pascalbetz — made your suggested adjustments. |
@@ -9,7 +10,7 @@ module Rendering | |||
# This is raised at the runtime when Lotus::Layout cannot find it's template. | |||
# | |||
# @since 0.3.0 | |||
class MissingTemplateLayoutError < ::StandardError | |||
class MissingTemplateLayoutError < Lotus::View::Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought: is there something like a search path in lotus or what extensions were searched? Then this would be useful information in the exception message.
@liamdawson Thank you, merging this. 👍 |
Subclass errors from a general Lotus module error
@liamdawson I've cleaned your PR with 847b7da, because I also moved all the errors in one file ( Can you please follow the same approach for the other frameworks? Thank you very much. ✨ |
Closes #81