request 0.3.1 assumes utf-8

[dickmao]

The tkf library now defaults to utf-8 encoding (so does not need to be
done in anki-editor). Further the synchronous bug has been fixed.

Closes #51 #49

[rogorido]

Which is the current status of this issue?

[louietan]

Thanks, but the changes to sync mode seems to make Emacs hanging.

[ejmg]

@dickmao I appreciate your effort into making this PR to work around this change.

It appears that in the PR, a snippet of code @louietan wrote to work around callbacks was removed. Could this be why emacs is hanging with this patch?

@dickmao was there a reason you removed this callback?

[louietan]

I'm debugging request.el, feels like the polling in request--curl-sync never ends and blocks the semaphore from being signaled.

I put some logs in that function and only get "Accepting process output..." and "Not finished yet, waiting...".

(let (finished)
    (prog1 (apply #'request--curl url
                  :semaphore (lambda (&rest _)
                               (request-log 'debug "Semaphore signaled !")
                               (setq finished t))
                  settings)
      (let ((proc (get-buffer-process (request-response--buffer response))))
        (with-local-quit
          (while (not finished)
            (if (request--process-live-p proc)
                (progn
                  (request-log 'debug "Accepting process output...")
                  (accept-process-output proc))
              (request-log 'debug "Not finished yet, waiting...")
              (sleep-for 0 300)))))))

[louietan]

Substitute sleep-for with sit-for works now. I'm gonna find out how they are different.

[louietan]

Not really works though, if I make some input events to emacs while it's requesting, it still deadlocks.

[louietan]

tkf/emacs-request#132

[leezu]

@dickmao can you remove the "synchronous bug has been fixed" related changes? Let's first fix the encoding issue. Once the "synchronous bug has been fixed" related changes have been debugged they can be merged in a separate PR. What do you think?

[dickmao]

You got it.

[leezu]

Thanks! @louietan can the utf-8 fix be merged then?

[yszhang95]

Hi, I have an similar issue to #54 . The platform is WINDOWS 11 and the EMCAS version is 28, NT.

Inspired by comments from @moerrari , I revert the line back. Now the repository functions. I am not sure if this is an issue or if I should report it here or elsewhere.

Thanks!