Temp file encoding of curl payloads

[gariepyalex]

When send an HTTP payload using curl, emacs-request make use of a temp file for the content of the payload. However, when the payloads contains non-ascii characters, the temporary file is encoded in latin1 instead of in utf-8.

The problem seems to come from there:
fb93d11

Changing the code to:

(let ((file-coding-system-alist nil)
             (coding-system-for-write 'utf-8))
         (with-temp-file tempfile
           (setq buffer-file-coding-system 'utf-8)
           (insert data)))

seems to fix the problem. I can open a pull request if you want.

[HIRANO-Satoshi]

Hi,

We have this issue with org-trello and all of non-English users could not use it.

@gariepyalex Could you kindly send a PR?

[MaksVal]

Hi!

Sorry, but your workaround isn't working for me... I changed your code a litle:

(setq buffer-file-coding-system 'utf-8)
       (insert data)
       (decode-coding-region (point-min) (point-max) 'utf-8)))

[titaniumbones]

Is there an alternative version of the request package that can be installed from melpa or somewhere else? This fix seems essential; I have stored the defun of request--curl-command in my init file (as part of the :config directive in a use-package invocation), but it seems like the better option would be for someone else to take over maintenance of the project. @DamienCassou have you thought about sharing your fork?

[DamienCassou]

Matt Price <notifications@github.com> writes:

@DamienCassou have you thought about sharing your fork?

I don't want to invest time in maintaining a fork right now.

…

-- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill

[titaniumbones]

Does #85 fix this issue for you @gariepyalex and @MaksVal ?

[MaksVal]

@titaniumbones this is a fine solution! Thanks!

[rogorido]

What is exactly the status of this issue? I have an issue with anki-editor (louietan/anki-editor#51) which seems related to this... (I'm using request 0.3.1, but with master I had the same problem)

[dickmao]

@rogorido We made a backwards incompatible change in release 0.3.1. louietan/anki-editor#53 updates your package to be compatible with 0.3.1. #128 attempts to mitigate other fallouts of this kind.

[MaksVal]

Yes, thanks you. пт, 30 нояб. 2018 г., 3:51 Matt Price <notifications@github.com>:

…

Does #85 <#85> fix this issue for you @gariepyalex <https://github.com/gariepyalex> and @MaksVal <https://github.com/MaksVal> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJpVj5aeXt57TFOhogAtY83xKJt0EHn8ks5u0IEmgaJpZM4Nivpa> .