Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to translate country names #11

Closed
NathanBnm opened this issue Jun 28, 2020 · 4 comments
Closed

Add a way to translate country names #11

NathanBnm opened this issue Jun 28, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@NathanBnm
Copy link
Contributor

Maybe with a matching list?

@louis77
Copy link
Owner

louis77 commented Jun 29, 2020

I've found a free database of translated country names here: https://github.com/mledoze/countries
(see countries.json).

Would you recommend to use PO to provide that country names or let the application handle the translation via a local mapping file?

@NathanBnm
Copy link
Contributor Author

I think it would be fine to use this database but there are not all the available languages. Maybe there can be some file in the app, kind of an enumeration which makes the list in English and can be added to po files. What do you think?

@louis77
Copy link
Owner

louis77 commented Aug 20, 2020

Work on this has begun. With the commit 96f9407 there is a file /src/Models/Countries.vala which contains a map with all country names as translatable strings.

The list was generated from here:
https://datahub.io/core/country-list#data

@louis77 louis77 added the enhancement New feature or request label Aug 20, 2020
@louis77 louis77 added this to the 1.3 milestone Aug 20, 2020
@NathanBnm
Copy link
Contributor Author

This can be closed according to #37 Don't know why it didn't close itself

@louis77 louis77 closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants