Resend Notification if Down X times consequently #1212

OidaTiftla · 2022-01-23T14:23:22Z

Description

This pull request will introduce a resend interval. The use case is the following: If a service is down a notification is sent. If the service is not fixed by time I want to get another notification after some time, for example one day.

I'm very new to pull requests, so I hope I've done everything correct. If there is anything I have forgotten please let me know, I will fix it.

Type of change

User interface (UI)
New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I ran ESLint and other linters for modified files
I have performed a self-review of my own code and tested it
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

package.json

server/server.js

Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>

OidaTiftla · 2022-01-31T11:52:56Z

Hello,

I'm new to this project and would like to know if there is anything I can do, so that this can be merged?

Best regards,
Christoph

Saibamen · 2022-01-31T20:42:46Z

@louislam

macedo · 2022-04-20T20:56:41Z

I'm very interested in this PR too, can I help with anything to get this merged?

server/model/monitor.js

src/pages/EditMonitor.vue

Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>

louislam · 2022-06-11T12:50:41Z

Thanks for the pull request.

Just tested, I think the feature is great, but I think the implementation is not what the name described.

For example:
Monitor Interval = 3600s
Notification Resend Interval = 60s
In this case, it won't send a notification for every 60s

My suggestion:

Rename it to something like Resend Notification if Down X times consequently.
Change last_notified_time to simple Down count, if Down X times, send it again.

Co-authored-by: Louis Lam <louislam@users.noreply.github.com>

OidaTiftla · 2022-06-15T15:51:42Z

@louislam thank you for your feedback and sorry for the late reply. Now I had time to integrate your suggestions.

You're right I didn't thought of this constellation, your description is the better one, thanks 👍.

I tested it again. You may now have a look again.

…terval # Conflicts: # src/pages/EditMonitor.vue

louislam · 2022-08-05T08:42:02Z

Just test this pr.

It seems that the notification was sent every time, but I set 2 times

OidaTiftla · 2022-08-05T10:19:06Z

Hi @louislam,

I tested it again and couldn't verify the failure you experienced. I had the following logging:

2022-08-05T10:12:45.659Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Check isImportant
2022-08-05T10:12:45.659Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] sendNotification
2022-08-05T10:12:45.660Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] apicache clear
2022-08-05T10:12:45.660Z [MONITOR] WARN: Monitor #1 '[Resend Noti] Resend every 2 times': Failing: getaddrinfo ENOTFOUND louislam.net2 | Interval: 20 seconds | Type: http | Down Count: 0 | Resend Interval: 2
2022-08-05T10:12:45.660Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Send to socket
2022-08-05T10:12:45.662Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Store
2022-08-05T10:12:45.732Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] prometheus.update
2022-08-05T10:12:45.732Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] SetTimeout for next check.
2022-08-05T10:13:05.734Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Prepare Options for axios
2022-08-05T10:13:05.735Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Axios Options: {"url":"https://louislam.net2","method":"get","timeout":16000,"headers":{"Accept":"text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9","User-Agent":"Uptime-Kuma/1.17.1"},"maxRedirects":10,"httpsAgent":{"_events":{},"_eventsCount":2,"defaultPort":443,"protocol":"https:","options":{"maxCachedSessions":0,"rejectUnauthorized":true,"path":null},"requests":{},"sockets":{},"freeSockets":{},"keepAliveMsecs":1000,"keepAlive":false,"maxSockets":null,"maxFreeSockets":256,"scheduling":"lifo","maxTotalSockets":null,"totalSocketCount":0,"maxCachedSessions":0,"_sessionCache":{"map":{},"list":[]}}}
2022-08-05T10:13:05.735Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Axios Request
2022-08-05T10:13:05.774Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Check isImportant
2022-08-05T10:13:05.775Z [MONITOR] WARN: Monitor #1 '[Resend Noti] Resend every 2 times': Failing: getaddrinfo ENOTFOUND louislam.net2 | Interval: 20 seconds | Type: http | Down Count: 1 | Resend Interval: 2
2022-08-05T10:13:05.775Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Send to socket
2022-08-05T10:13:05.776Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Store
2022-08-05T10:13:05.867Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] prometheus.update
2022-08-05T10:13:05.867Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] SetTimeout for next check.
2022-08-05T10:13:25.873Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Prepare Options for axios
2022-08-05T10:13:25.874Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Axios Options: {"url":"https://louislam.net2","method":"get","timeout":16000,"headers":{"Accept":"text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9","User-Agent":"Uptime-Kuma/1.17.1"},"maxRedirects":10,"httpsAgent":{"_events":{},"_eventsCount":2,"defaultPort":443,"protocol":"https:","options":{"maxCachedSessions":0,"rejectUnauthorized":true,"path":null},"requests":{},"sockets":{},"freeSockets":{},"keepAliveMsecs":1000,"keepAlive":false,"maxSockets":null,"maxFreeSockets":256,"scheduling":"lifo","maxTotalSockets":null,"totalSocketCount":0,"maxCachedSessions":0,"_sessionCache":{"map":{},"list":[]}}}
2022-08-05T10:13:25.874Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Axios Request
2022-08-05T10:13:25.924Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Check isImportant
2022-08-05T10:13:25.924Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] sendNotification again: Down Count: 2 | Resend Interval: 2
2022-08-05T10:13:25.925Z [MONITOR] WARN: Monitor #1 '[Resend Noti] Resend every 2 times': Failing: getaddrinfo ENOTFOUND louislam.net2 | Interval: 20 seconds | Type: http | Down Count: 0 | Resend Interval: 2
2022-08-05T10:13:25.926Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Send to socket
2022-08-05T10:13:25.926Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] Store
2022-08-05T10:13:26.004Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] prometheus.update
2022-08-05T10:13:26.004Z [MONITOR] DEBUG: [[Resend Noti] Resend every 2 times] SetTimeout for next check.

The timestamps between the sendNotification messages have exactly 40 seconds in between. This is what I expect.

Is there any setting I missed, that produces this failure? May you have an idea? Please let me know, so I can verify and fix the problem.

Best regards, Christoph

louislam · 2022-08-13T05:23:33Z

Oh, I forget to re-run the db patch again. It's ok now.

…terval # Conflicts: # server/database.js

OidaTiftla · 2022-08-16T06:27:55Z

Great, thanks a lot for merging this.

skylarv · 2023-02-08T23:28:47Z

@louislam Shouldn't "consequently" be "consecutively". Seems like a typo?

louislam · 2023-02-09T06:39:41Z

@louislam Shouldn't "consequently" be "consecutively". Seems like a typo?

You are right, I messed up both words.

louislam#1212 (comment)

OidaTiftla · 2023-02-09T08:45:42Z

Hi @louislam,

I updated the code in #2747 you may have a look.

Best regards.

Introduce resend interval if down

1ac904d

OidaTiftla changed the title ~~Introduce resend interval if down~~ Draft: Introduce resend interval if down Jan 23, 2022

OidaTiftla changed the title ~~Draft: Introduce resend interval if down~~ Introduce resend interval if down Jan 23, 2022

OidaTiftla marked this pull request as draft January 23, 2022 15:54

Saibamen suggested changes Jan 23, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

server/server.js Outdated Show resolved Hide resolved

OidaTiftla and others added 9 commits January 23, 2022 17:35

Fix formatting

b69a8b8

Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>

Revert version change

65fc71e

Change seconds to minutes

11e9eee

Add database patch

f931e70

Simplify

8c4ab9d

Fix min value of resend interval

30ce53f

Fix missing DB patch and use DATETIME as column format

f390a8c

Add text for resend disabled

855b12f

Add german translation

d446a57

OidaTiftla marked this pull request as ready for review January 24, 2022 21:25

OidaTiftla and others added 2 commits March 27, 2022 21:19

Merge branch 'master' into introduce-resend-interval

91366ff

Update version after merging new master branch

d8013f3

OidaTiftla and others added 3 commits April 21, 2022 11:58

Merge branch 'master' into introduce-resend-interval

b7e2489

Use new logging mechanism

60f8ab7

Improve backwards compatibility

19933bb

Computroniks suggested changes Apr 21, 2022

View reviewed changes

server/model/monitor.js Outdated Show resolved Hide resolved

src/pages/EditMonitor.vue Outdated Show resolved Hide resolved

OidaTiftla and others added 3 commits April 21, 2022 17:45

Make comment more readable

d6b591a

Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>

Fix casing of text label

052fde5

Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>

Add translation for text label

c7ec9a0

Computroniks approved these changes Apr 21, 2022

View reviewed changes

Fix trailing space warning

7ed8ae9

gaby mentioned this pull request May 3, 2022

How can i notify each X minutes current alerts #1607

Closed

2 tasks

Saibamen approved these changes May 5, 2022

View reviewed changes

louislam added this to the 1.17.0 milestone May 7, 2022

louislam added the question Further information is requested label Jun 13, 2022

louislam modified the milestones: 1.17.0, Pending Jun 14, 2022

Merge branch 'master' into introduce-resend-interval

869a040

OidaTiftla changed the title ~~Introduce resend interval if down~~ Resend Notification if Down X times consequently Jun 15, 2022

Rename feature to: Resend Notification if Down X times consequently

ac27e6e

Co-authored-by: Louis Lam <louislam@users.noreply.github.com>

louislam modified the milestones: Pending, 1.18.0 Jun 15, 2022

Gottarocket mentioned this pull request Jul 31, 2022

Improve notification #1956

Closed

1 task

louislam removed the question Further information is requested label Aug 5, 2022

Merge remote-tracking branch 'origin/master' into introduce-resend-in…

d0d1e0d

…terval # Conflicts: # src/pages/EditMonitor.vue

louislam added the question Further information is requested label Aug 5, 2022

mabed-fr mentioned this pull request Aug 12, 2022

Acknowledge PROBE/NOTIFICATION #1989

Open

1 task

Merge remote-tracking branch 'origin/master' into introduce-resend-in…

de6e1e7

…terval # Conflicts: # server/database.js

louislam merged commit 30b72d8 into louislam:master Aug 13, 2022

OidaTiftla deleted the introduce-resend-interval branch August 16, 2022 06:22

OidaTiftla added a commit to OidaTiftla/uptime-kuma that referenced this pull request Feb 9, 2023

Rename "consequently" to "consecutively" as suggested by @skylarv

36d160a

louislam#1212 (comment)

OidaTiftla mentioned this pull request Feb 9, 2023

Rename "consequently" to "consecutively" as suggested by @skylarv #2747

Merged

7 tasks

chakflying mentioned this pull request Jul 30, 2023

Continuous notifications #1742

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resend Notification if Down X times consequently #1212

Resend Notification if Down X times consequently #1212

OidaTiftla commented Jan 23, 2022 •

edited

OidaTiftla commented Jan 31, 2022

Saibamen commented Jan 31, 2022

macedo commented Apr 20, 2022

louislam commented Jun 11, 2022 •

edited

OidaTiftla commented Jun 15, 2022

louislam commented Aug 5, 2022

OidaTiftla commented Aug 5, 2022

louislam commented Aug 13, 2022

OidaTiftla commented Aug 16, 2022

skylarv commented Feb 8, 2023

louislam commented Feb 9, 2023

OidaTiftla commented Feb 9, 2023

Resend Notification if Down X times consequently #1212

Resend Notification if Down X times consequently #1212

Conversation

OidaTiftla commented Jan 23, 2022 • edited

Description

Type of change

Checklist

Screenshots (if any)

OidaTiftla commented Jan 31, 2022

Saibamen commented Jan 31, 2022

macedo commented Apr 20, 2022

louislam commented Jun 11, 2022 • edited

OidaTiftla commented Jun 15, 2022

louislam commented Aug 5, 2022

OidaTiftla commented Aug 5, 2022

louislam commented Aug 13, 2022

OidaTiftla commented Aug 16, 2022

skylarv commented Feb 8, 2023

louislam commented Feb 9, 2023

OidaTiftla commented Feb 9, 2023

OidaTiftla commented Jan 23, 2022 •

edited

louislam commented Jun 11, 2022 •

edited