Status page certificate expiry - #3357
Conversation
|
@louislam This pull request is ready fo review, let me know if we need any style changes on how expiry is shown on the status page |
| @click="$refs.monitorSettingDialog.show(group, monitor)" | ||
| /> | ||
| </span> | ||
| <p v-if="showCertificateExpiry" class="item-name"> Expiry: {{ formatExpiry(monitor) }} </p> |
There was a problem hiding this comment.
Disclaimer: I am not a designer => feel free to overrule
From a design perspective, I don't like how this looks like a regular title (a user would not be able to pick up, that this is an expiry notice).
What do you think: Could we move this to a subtle or tag and still keep the current design?
There was a problem hiding this comment.
Should i try showing it as pill like the uptime percetage, with colors for showing how soon it will be expiring?
My reason for avoiding that was to not clutter the ui.
There was a problem hiding this comment.
Yes, a pill is what I meant with tag. This would be one option.
There was a problem hiding this comment.
Here's the pill/tags based design i came up with, which one do you prefer?
-
Expiry inside the pill
-
Expiry outside the pill
I think second option looks much better but name of the monitor is getting confusing.
Color is green for expiry of more than 7 days
Color is red for everything else
There was a problem hiding this comment.
@louislam Do you have any preference out of the above two designs?
… status-page-expiry
CommanderStorm
left a comment
CommanderStorm
left a comment
There was a problem hiding this comment.
My concerns have been addressed. (if you mark them as resolved, they are not shown any more ^^)
I (not a desiger/bdfl => this requires Louis vote) am unsure if the Pills' design fits, but I think this has a solid chance and looks close enough.
|
Expiry should not be shown if monitor type is not HTTPS. |
|
I might prefer to put in front of the tag list. Like this. |
|
I have incorporated tags design as suggested by @louislam and added check for monitor type (@chakflying ). |
3f5641d to
f6c1b92
Compare
… status-page-expiry
|
This is ready to be merged @CommanderStorm & @louislam |
|
Could you add |
|
And also |
I think this is included in #1610 => no need to create another issue |
# Conflicts: # src/lang/en.json
5 participants
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #2451
Fixes #3456
Fixes #2522
Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)