Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status page certificate expiry #3357
Status page certificate expiry #3357
Changes from 1 commit
4ea5771
b1f266c
6f4af30
ad3ffac
2e75142
f6c1b92
50d4091
7f68e4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: I am not a designer => feel free to overrule
From a design perspective, I don't like how this looks like a regular title (a user would not be able to pick up, that this is an expiry notice).
What do you think: Could we move this to a subtle or tag and still keep the current design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should i try showing it as pill like the uptime percetage, with colors for showing how soon it will be expiring?
My reason for avoiding that was to not clutter the ui.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, a pill is what I meant with tag. This would be one option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the pill/tags based design i came up with, which one do you prefer?
Expiry inside the pill
![Screenshot 2023-07-06 at 1 36 50 PM](https://private-user-images.githubusercontent.com/12068093/251527963-36b90afa-0459-4f93-a62d-d795d2997247.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NDk0ODMsIm5iZiI6MTcyMTc0OTE4MywicGF0aCI6Ii8xMjA2ODA5My8yNTE1Mjc5NjMtMzZiOTBhZmEtMDQ1OS00ZjkzLWE2MmQtZDc5NWQyOTk3MjQ3LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDE1Mzk0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY5MmYwYzQyYzY0ZWU4OTk5YTMwN2Q4YzQ0MmU5MDllN2ZmZDQ4N2U4NDU5YTkyN2Y3YzkxMjNhNGZlNjZmNTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kfcjuVi8rMEYIgJaaL0G-TWLyJ3jP1hES0J0WP9ZBeY)
Expiry outside the pill
![Screenshot 2023-07-06 at 1 35 46 PM](https://private-user-images.githubusercontent.com/12068093/251527965-50888fa0-3b6e-468d-838c-40d00baca845.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NDk0ODMsIm5iZiI6MTcyMTc0OTE4MywicGF0aCI6Ii8xMjA2ODA5My8yNTE1Mjc5NjUtNTA4ODhmYTAtM2I2ZS00NjhkLTgzOGMtNDBkMDBiYWNhODQ1LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDE1Mzk0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlhNDIwMTI2MjFlNWYxZDU4ZDhjNTIxNjYzNzQ3YmQ0ZWY0NGE3MjRhMjViNjM3ZmJhNjgwYTIyODhlN2MwZGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.wUZY0oBzkmMmm8wFPbXOMulLP_DFCwCWaNd4WmoOeU8)
I think second option looks much better but name of the monitor is getting confusing.
Color is green for expiry of more than 7 days
Color is red for everything else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@louislam Do you have any preference out of the above two designs?