Fix handling of IPv6 addresses in getClientIP #3381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
This PR fixes the handling of IPv6 addresses in
getClientIP
. Currently this method fails to handle IPv6 addresses correctly. E.g. my log shows:when I logged in from
xxxx:xxxx:xxxx:xxxx:59a9:4a64:bea4:ca44
.This is fixed by not blindly removing anything prefix the
:
, but only the relevant part (I suspect that this as been introduced in the first place to remove the prefix of IPv4-mapped IPv6 addresses):The log now contains:
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.