Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python2 support and EOL #49

Closed
edouard-lopez opened this issue Apr 24, 2019 · 3 comments
Closed

Python2 support and EOL #49

edouard-lopez opened this issue Apr 24, 2019 · 3 comments

Comments

@edouard-lopez
Copy link

I saw you have code to support Python 2.7. This version will not be maintained past january 2020.

If you want to support it anyway, yet simplify your code, you could use future module. Then for above code simply do:

 from builtins import input
@lovato
Copy link
Owner

lovato commented Apr 26, 2019

Well, at first, I was willing to make hooks4git a python dependency, then once you clone a project an install everything, it would auto hook your folder. But this happens only the first time when the package is still in egg format. Then it is converted (and cached) to wheel, which doesn't execute code upon installation.

So I would be willing to remove all this user wizard input, since making it behave like a tool created a simpler workflow.

Like, it is simpler not being able to do something and ask for a --force parameter, than handle a dialog with the user.

@edouard-lopez
Copy link
Author

Ok, didn't realize you are not using this method. So could be delete

Using flags is indeed a better solution IMHO.

@lovato
Copy link
Owner

lovato commented Apr 26, 2019

Well, it is already deleted on develop. I did some work adding a few more tests, and a cleanup. Right now hooks4git is using 'itself' inside CI on develop. I have a few more details to catch on develop, and then I will release another version.
Then, start working on a major rework allowing code to be tested.

@lovato lovato closed this as completed Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants