Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can sharp expose remaining parameters of vips_sharpen() #2935

Closed
Rochel23 opened this issue Oct 19, 2021 · 3 comments
Closed

Can sharp expose remaining parameters of vips_sharpen() #2935

Rochel23 opened this issue Oct 19, 2021 · 3 comments

Comments

@Rochel23
Copy link

@Rochel23 Rochel23 commented Oct 19, 2021

I am trying to do unsharpmasking using sharp library. I am using sharpen operation to do so and I require the parameter flat/jaggy threshold(x1) to achieve the expected output .
As far as I understand, the parameters x1, y2 and y3 are not-yet-exposed. #708
Are these parameters planned to be exposed in near future? Can this be included in the new feature request? Or is there a way to achieve threshold(x1) for sharpen operation?

@lovell
Copy link
Owner

@lovell lovell commented Oct 19, 2021

Happy to accept a PR that exposes these, if you're able.

@Rochel23
Copy link
Author

@Rochel23 Rochel23 commented Oct 28, 2021

I tried to look into the code, but I am no expert in cpp. Though it would be great to have this feature.

@lovell lovell added this to the v0.30.3 milestone Mar 9, 2022
lovell added a commit that referenced this issue Mar 9, 2022
@lovell
Copy link
Owner

@lovell lovell commented Mar 14, 2022

These are now available as of v0.30.3

https://sharp.pixelplumbing.com/api-operation#sharpen

@lovell lovell closed this as completed Mar 14, 2022
martinj pushed a commit to aptoma/sharp that referenced this issue Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants