Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading images through ImageMagick as a buffer #165

Merged
merged 1 commit into from
Feb 16, 2015

Conversation

mcuelenaere
Copy link
Contributor

@mcuelenaere
Copy link
Contributor Author

This fixes #162.

@mcuelenaere
Copy link
Contributor Author

Not sure how to fix the errors found by the CIs: moving the header checks into a separate function is a possible solution here I suppose?

Incidentally, #166 should also fix this I presume.

@lovell
Copy link
Owner

lovell commented Feb 15, 2015

Fantastic, thanks for both this and the upstream libvips changes to allow it. I'll let John merge in your PR first.

The test failure is due to a high water mark I've added for cyclomatic complexity. As you say, moving this logic to C++ land will reduce the complexity here.

@mcuelenaere
Copy link
Contributor Author

I changed the minimum version requirements to >= 8.0, as that's what John says in https://github.com/jcupitt/libvips/pull/241.

@lovell lovell merged commit ab7408c into lovell:master Feb 16, 2015
@lovell
Copy link
Owner

lovell commented Feb 16, 2015

I updated a few #if preprocessor statements to accommodate the forthcoming libvips major version increment - see f89e9d7

Thanks again for this - I'll update the docs and provide a credit for your good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants