Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation for withoutEnlargement #990

Closed
wants to merge 1 commit into from

Conversation

moyvera
Copy link

@moyvera moyvera commented Oct 13, 2017

Fixes the issue docs:withoutEnlargement #972

Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for this. One small grammar/spelling change and this will be good to merge.

@@ -274,6 +274,8 @@ function ignoreAspectRatio () {
* Do not enlarge the output image if the input image width *or* height are already less than the required dimensions.
* This is equivalent to GraphicsMagick's `>` geometry option:
* "*change the dimensions of the image only if its width or height exceeds the geometry specification*".
*
* The default value will be *true* only if you call explitely `withoutEnlargement`, otherwise will be *false*.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call explitely => explicitly call

@coveralls
Copy link

coveralls commented Oct 13, 2017

Coverage Status

Coverage remained the same at 99.325% when pulling 10c1afa on moyvera:fix-withoutEnlargement-docs into bbe897e on lovell:master.

@lovell
Copy link
Owner

lovell commented Oct 15, 2017

Hello, this has been superseded by #992. Thanks again for this PR - they are always welcome.

@lovell lovell closed this Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants