Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using codec for keys #254

Closed
RiiD opened this issue May 1, 2020 · 2 comments
Closed

Support using codec for keys #254

RiiD opened this issue May 1, 2020 · 2 comments

Comments

@RiiD
Copy link

RiiD commented May 1, 2020

I am wondering if the community need the ability for specifying custom codec for the message key. It would be needed when using Kafka with something like schema manager for sharing schema or when the key is composite. I am working on adding this functionality to Goka here. I was doing it backward compatible as much as I can, but some API has changed. If this is needed and breaking the API can be tolerated I can create a PR into this repo. Also, I have some spare time (thanks corona :) ) so I can invest it here.
So WDYT?

@frairon
Copy link
Contributor

frairon commented May 7, 2020

Hi @RiiD, thanks for your time and the offer! Thanks to Corona I have much less time, so it's just fair :).
I think the topic with key-codecs came up once or twice, but without specific use case like a schema manager (which makes the whole thing more interesting actually). So we didn't follow up as no one really needed it.
So for us, string keys are fine, no need to have codecs. But let's hear what other people think.

One thing though: if you plan on keeping goka up to date in the fork (or eventually PR back), you need to fork from branch consumer-group, which is our current development branch for a majorly refactored version of Goka. Checkout #239 for details. Forking from master will let you end up with a ton of conflicts. Sorry :)

@frairon
Copy link
Contributor

frairon commented Sep 30, 2021

the issue was inactive for over a year now, I'll close it. Feel free to reopen if you see a need for action.

@frairon frairon closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants