Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dv] Add riscv_ram_intg_test #2184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nasahlpa
Copy link
Member

@nasahlpa nasahlpa commented Jul 2, 2024

This test injects a fault into different MuBi encoded signals within the prim_ram_1p_scr and prim_ram_1p_adv and checks whether a fatal alert is triggered.

I have excluded the addr_match signal from FI as its encoding is not directly checked. If the signal was a MuBi True, a fault into it is treated by the mubi4_and_hi as a False. If the signal was a MuBi False, a fault into it is treated by the mubi4_and_hi also as a False. Hence, no address collision occurs and the holding register is not returned.

This PR is based on #2182 and closes #2173.

Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. One nitty question about ^=, but I'm happy either way!

dv/uvm/core_ibex/tests/core_ibex_test_lib.sv Outdated Show resolved Hide resolved
@nasahlpa nasahlpa force-pushed the ibex_fi_tests branch 3 times, most recently from 4b7c5aa to bb81156 Compare July 2, 2024 12:46
This test injects a fault into different MuBi encoded signals within
the prim_ram_1p_scr and prim_ram_1p_adv and checks whether a fatal
alert is triggered.

I have excluded the addr_match signal from FI as its encoding
is not directly checked. If the signal was a MuBi True, a
fault into it is treated by the mubi4_and_hi as a False.
If the signal was a MuBi False, a fault into it is treated
by the mubi4_and_hi also as a False. Hence, no address
collision occurs and the holding register is not returned.

This PR is based on lowRISC#2182 and closes lowRISC#2173.

Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dv] Implement fault injection tests for prim_ram_1p_scr MUBI values
2 participants