Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rom_ext] ROM_EXT Recovery mode #19151

Closed
dmcardle opened this issue Jul 10, 2023 · 2 comments
Closed

[rom_ext] ROM_EXT Recovery mode #19151

dmcardle opened this issue Jul 10, 2023 · 2 comments
Assignees
@dmcardle
Labels
Component:Software Issue related to Software SW:ROM_EXT ROM_EXT related issues
Milestone
Earlgrey ES ROM_EXT

Comments

@dmcardle
Copy link
Contributor

dmcardle commented Jul 10, 2023 •
edited

OpenTitan ROM_EXT Recovery Mode

This issue tracks the implementation of the ROM_EXT Recovery mode, which enables the silicon owner to the parts of flash not occupied by ROM_EXT.

N.B. We are shifting terminology from "ROM_EXT Recovery" to "ROM_EXT Bootstrap".
@dmcardle dmcardle added Component:Software Issue related to Software SW:ROM_EXT ROM_EXT related issues labels Jul 10, 2023
@dmcardle dmcardle self-assigned this Jul 10, 2023
dmcardle added a commit to dmcardle/opentitan that referenced this issue Jul 10, 2023
@dmcardle
[sw/silicon_creator] Move rom/bootstrap.c to lib/reflash.c
5bd796d 
The goal of the overarching refactor is to move bootstrap code into a
library that can be shared by ROM Bootstrap and ROM_EXT Recovery.

This commit renames bootstrap.c and does a little surgery on BUILD files
to ensure the bootstrap library still builds. Splitting this refactor
into two commits preserves bootstrap.c's edit history.

Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Jul 10, 2023
@dmcardle
[sw/silicon_creator] Refactor bootstrap and reflash libraries
4f5463a 
Now, bootstrap() in bootstrap.c checks whether bootstrap is requested,
but farms out the SPI loop to the reflash library.

Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
@dmcardle dmcardle mentioned this issue Jul 10, 2023
Merged
dmcardle added a commit to dmcardle/opentitan that referenced this issue Jul 11, 2023
@dmcardle
[sw/silicon_creator] Move ROM bootstrap impl into common library
9707ba1 
The goal of the overarching refactor is to move bootstrap code into a
library that can be shared by ROM and ROM_EXT. This will enable us to
share code between the two variants of bootstrap. (ROM_EXT bootstrap is
also referred to as "recovery".)

This commit renames bootstrap.c and does a little surgery on BUILD files
to ensure the bootstrap library still builds. Splitting this refactor
into two commits preserves bootstrap.c's edit history.

Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Jul 11, 2023
@dmcardle
[sw/silicon_creator] Refactor bootstrap and reflash libraries
33278d6 
Now, bootstrap() in bootstrap.c checks whether bootstrap is requested,
but delegates the SPI loop to the common bootstrap library.

Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Jul 11, 2023
@dmcardle
[sw/silicon_creator] Refactor bootstrap and reflash libraries
36bca86 
Now, bootstrap() in bootstrap.c checks whether bootstrap is requested,
but delegates the SPI loop to the common bootstrap library.

Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Jul 11, 2023
@dmcardle
[sw/silicon_creator] Refactor bootstrap and reflash libraries
93d211e 
Now, bootstrap() in bootstrap.c checks whether bootstrap is requested,
but delegates the SPI loop to the common bootstrap library.

Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit that referenced this issue Jul 11, 2023
@dmcardle
[sw/silicon_creator] Move ROM bootstrap impl into common library
dda1245 
The goal of the overarching refactor is to move bootstrap code into a
library that can be shared by ROM and ROM_EXT. This will enable us to
share code between the two variants of bootstrap. (ROM_EXT bootstrap is
also referred to as "recovery".)

This commit renames bootstrap.c and does a little surgery on BUILD files
to ensure the bootstrap library still builds. Splitting this refactor
into two commits preserves bootstrap.c's edit history.

Issue #19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit that referenced this issue Jul 11, 2023
@dmcardle
[sw/silicon_creator] Refactor bootstrap and reflash libraries
b68e86b 
Now, bootstrap() in bootstrap.c checks whether bootstrap is requested,
but delegates the SPI loop to the common bootstrap library.

Issue #19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
@dmcardle dmcardle mentioned this issue Jul 25, 2023
Merged
dmcardle added a commit to dmcardle/opentitan that referenced this issue Jul 31, 2023
@dmcardle
[sw] Implement ROM_EXT recovery
81e5a3c 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Jul 31, 2023
@dmcardle
[sw] Implement ROM_EXT recovery
0826752 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit that referenced this issue Jul 31, 2023
@dmcardle
[sw] Implement ROM_EXT recovery
934678a 
Issue #19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 1, 2023
@dmcardle
[rom_ext_e2e] Sketch bootstrap test plan in rom_ext/e2e/README.md
55f9076 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 1, 2023
@dmcardle
[rom_ext_e2e] Sketch bootstrap test plan in rom_ext/e2e/README.md
16a3b17 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
alphan pushed a commit that referenced this issue Aug 1, 2023
@dmcardle @alphan
[rom_ext_e2e] Sketch bootstrap test plan in rom_ext/e2e/README.md
d490ee8 
Issue #19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
bilgiday pushed a commit to bilgiday/opentitan that referenced this issue Aug 7, 2023
@dmcardle @bilgiday
[sw] Implement ROM_EXT recovery
e91e7ff 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
bilgiday pushed a commit to bilgiday/opentitan that referenced this issue Aug 7, 2023
@dmcardle @bilgiday
[rom_ext_e2e] Sketch bootstrap test plan in rom_ext/e2e/README.md
64d453b 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 9, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
ad90aa4 
Issue lowRISC#19151
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 9, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
68c3db8 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 9, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
167389e 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
@dmcardle dmcardle mentioned this issue Aug 9, 2023
Merged
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 9, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
ed469e5 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 11, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
534bf17 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 14, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
841f323 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 14, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
739b5c4 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 21, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
0b46f83 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 22, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
665bcef 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 22, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
fe79235 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 22, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
ba22419 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 30, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
4976769 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 30, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
19cef7e 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 30, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
94784f5 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit to dmcardle/opentitan that referenced this issue Aug 31, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
8536a52 
Issue lowRISC#19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle added a commit that referenced this issue Aug 31, 2023
@dmcardle
[sw/silicon_creator] Add memory protection feature to flash_ctrl driver
1cd3cbb 
Issue #19151

Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
@timothytrippel timothytrippel added this to the Earlgrey ES ROM_EXT milestone Sep 1, 2023
This was referenced Sep 1, 2023
Open
Open
@timothytrippel
Copy link
Contributor

This is being called "Rescue" now. Additionally, it is being tracked in #19590, #19591, and #19592. So I think we can close this now?

@timothytrippel timothytrippel changed the title [sw/silicon_creator] ROM_EXT Recovery mode [rom_ext] ROM_EXT Recovery mode Sep 1, 2023
@arunthomas
Copy link
Contributor

Yup, makes sense to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmcardle dmcardle

Labels
Component:Software Issue related to Software SW:ROM_EXT ROM_EXT related issues
Projects
None yet
Milestone
Earlgrey ES ROM_EXT
Development

No branches or pull requests
3 participants
@arunthomas @dmcardle @timothytrippel