[sw/silicon_creator] Refactor ROM bootstrap into a common lib #19155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphan
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Do you want to keep the name of this file or rename it to reflash? Asking because of our recent renaming chat.
bootstrap, creator_bootstrap or bootstrap_creator, owner_bootstrap or bootstrap_owner, etc.
we can also consider rom_(ext_)bootstrap and bl0_bootstrap.
There was a problem hiding this comment.
Per our chat, I edited each commit to rename the reflash library to bootstrap. Now we have two libraries named "bootstrap", but one lives in sw/device/silicon_creator/lib/ and the other is in sw/device/silicon_creator/rom/. I've named the lib variant of the function enter_bootstrap(), and I figured I'd preserve the bootstrap() function's name so we don't have to update call sites.
The goal of the overarching refactor is to move bootstrap code into a library that can be shared by ROM and ROM_EXT. This will enable us to share code between the two variants of bootstrap. (ROM_EXT bootstrap is also referred to as "recovery".) This commit renames bootstrap.c and does a little surgery on BUILD files to ensure the bootstrap library still builds. Splitting this refactor into two commits preserves bootstrap.c's edit history. Issue lowRISC#19151 Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle
force-pushed
the
dmcardle/bootstrap-refactor2
branch
2 times, most recently
from
f87ecd1
to
1087e33
Compare
Now, bootstrap() in bootstrap.c checks whether bootstrap is requested, but delegates the SPI loop to the common bootstrap library. Issue lowRISC#19151 Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
…akfast This is based on the solution to issue lowRISC#12905. Signed-off-by: Dan McArdle <dmcardle@opentitan.org>
dmcardle
force-pushed
the
dmcardle/bootstrap-refactor2
branch
from
1087e33
to
639ccec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior-preserving refactor moves the implementation of ROM bootstrap into a common library for use by ROM and ROM_EXT. This will support the implementation of ROM_EXT Recovery.
Note to reviewers: this is significantly easier to read one commit at a time. I was careful to preserve the original history of rom/bootstrap.c when I moved it to
reflash.clib/bootstrap.c, but looking at the PR as a whole obscures the actual changes.Issue #19151