Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dif/spi_device] To get SRAM size from parameter #5369

Closed
eunchan opened this issue Feb 24, 2021 · 3 comments · Fixed by #20942
Closed

[dif/spi_device] To get SRAM size from parameter #5369

eunchan opened this issue Feb 24, 2021 · 3 comments · Fixed by #20942
Assignees
Labels
Component:Software Issue related to Software Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Priority:P3 Priority: low SW:DIF Type:Enhancement Feature requests, enhancements Type:Icebox Changes deferred to future milestones

Comments

@eunchan
Copy link
Contributor

eunchan commented Feb 24, 2021

as discussed in #5145 and implemented in #5264, SPI_DEVICE HWIP now defines SRAM size in the module parameter. This issue is to follow up the change in the software (DIF). Currently, SRAM size in dif_spi_device is hard-coded. It will be more flexible if dif also use the parameter.

CC: @tjaychen

@eunchan eunchan added Component:Software Issue related to Software Priority:P3 Priority: low Type:Enhancement Feature requests, enhancements labels Feb 24, 2021
@moidx moidx added the SW:DIF label Mar 1, 2022
@moidx moidx unassigned gkelly Mar 1, 2022
@andreaskurth
Copy link
Contributor

Triaged for spi_device. Labeling Type:Icebox Changes deferred to future milestones as I think this is relevant for this release but not for the next milestone (M2.5).

@andreaskurth andreaskurth added Type:Icebox Changes deferred to future milestones Triaged labels Feb 24, 2023
@a-will
Copy link
Contributor

a-will commented Feb 24, 2023

Confirmation can come later, but it looks like this might specifically refer to kFifoPhaseMask and kFifoPhaseOffset in the DIFs.

@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 6, 2023
@msfschaffner msfschaffner added this to the Earlgrey-PROD.M2 milestone Nov 3, 2023
@a-will
Copy link
Contributor

a-will commented Jan 13, 2024

Generic mode is to be removed, so the original intention no longer applies. However, it might be useful to have the breakdown of flash mode parts and their offsets come from regtool-generated params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Software Issue related to Software Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Priority:P3 Priority: low SW:DIF Type:Enhancement Feature requests, enhancements Type:Icebox Changes deferred to future milestones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants