Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flash_ctrl] Use redundant arbiters in scrambling module #22091

Merged
merged 1 commit into from Mar 19, 2024

Conversation

msfschaffner
Copy link
Contributor

@msfschaffner msfschaffner commented Mar 18, 2024

I am not sure but I believe we do not yet have CM assertions similar to the sparse FSM or prim_count assertions for the duplicated arbiter.

We may want to fix that for PROD.M3 or PROD.M4: #12301

Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wasn't aware we have hardened arbiters available!

@vogelpi
Copy link
Contributor

vogelpi commented Mar 18, 2024

We need to run cmdgen again for this PR.

Signed-off-by: Michael Schaffner <msf@opentitan.org>
@vogelpi
Copy link
Contributor

vogelpi commented Mar 18, 2024

Update: I've run cmdgen and force-pushed. Will merge the PR once CI finishes.

@vogelpi
Copy link
Contributor

vogelpi commented Mar 18, 2024

The CI (Quality (in-depth lint)) failure is unrelated to this PR and due to the Verible style lint version change having landed too soon.

@vogelpi vogelpi merged commit a63c2d9 into lowRISC:master Mar 19, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants