-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ascon/doc] add specification in markdown #22262
Conversation
3f9a724
to
b7c2b13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text looks fine for me. However, I think the formatting of the markdown file needs to be improved, there are a lot of double line breaks and unintended text blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this conversion to Markdown, @m-temp. This is an approved RFC, so LGTM. Only one thing should be changed, please: Most SVGs are currently much larger (width and height) than their content; could you please crop the 'page size' to the content?
Thx @andreaskurth for the review!
Ups. looks like the svg export of google-docs/draws adds some space here. |
587b09d
to
165f0a9
Compare
I changed ASCON => Ascon. And did an auto-generated update on the register.md to match the latest improvements. |
Signed-off-by: Michael Tempelmeier <michael.tempelmeier@gi-de.com>
Signed-off-by: Michael Tempelmeier <michael.tempelmeier@gi-de.com>
Signed-off-by: Michael Tempelmeier <michael.tempelmeier@gi-de.com>
Signed-off-by: Michael Tempelmeier <michael.tempelmeier@gi-de.com>
This adds the https://docs.google.com/document/d/1hTnnhm5SoVCBYWObaTSfTLuKE07erR1ZapirLuR6YGU/edit as markdown.
See #22178