Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ascon/doc] add specification in markdown #22262

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

m-temp
Copy link
Contributor

@m-temp m-temp commented Mar 26, 2024

@m-temp m-temp force-pushed the ascon_doc branch 2 times, most recently from 3f9a724 to b7c2b13 Compare March 26, 2024 13:47
@Razer6 Razer6 mentioned this pull request Mar 26, 2024
@m-temp m-temp marked this pull request as ready for review March 27, 2024 11:47
Copy link
Member

@nasahlpa nasahlpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks fine for me. However, I think the formatting of the markdown file needs to be improved, there are a lot of double line breaks and unintended text blocks.

hw/ip/ascon/README.md Outdated Show resolved Hide resolved
hw/ip/ascon/README.md Outdated Show resolved Hide resolved
hw/ip/ascon/README.md Outdated Show resolved Hide resolved
hw/ip/ascon/README.md Outdated Show resolved Hide resolved
hw/ip/ascon/doc/background.md Show resolved Hide resolved
hw/ip/ascon/doc/background.md Outdated Show resolved Hide resolved
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this conversion to Markdown, @m-temp. This is an approved RFC, so LGTM. Only one thing should be changed, please: Most SVGs are currently much larger (width and height) than their content; could you please crop the 'page size' to the content?

@m-temp
Copy link
Contributor Author

m-temp commented Apr 8, 2024

Thx @andreaskurth for the review!

Thanks for this conversion to Markdown, @m-temp. This is an approved RFC, so LGTM. Only one thing should be changed, please: Most SVGs are currently much larger (width and height) than their content; could you please crop the 'page size' to the content?

Ups. looks like the svg export of google-docs/draws adds some space here.
I'll change that!

@m-temp m-temp force-pushed the ascon_doc branch 3 times, most recently from 587b09d to 165f0a9 Compare April 8, 2024 14:57
SUMMARY.md Outdated Show resolved Hide resolved
@m-temp
Copy link
Contributor Author

m-temp commented Apr 10, 2024

I changed ASCON => Ascon. And did an auto-generated update on the register.md to match the latest improvements.

Signed-off-by: Michael Tempelmeier <michael.tempelmeier@gi-de.com>
Signed-off-by: Michael Tempelmeier <michael.tempelmeier@gi-de.com>
Signed-off-by: Michael Tempelmeier <michael.tempelmeier@gi-de.com>
Signed-off-by: Michael Tempelmeier <michael.tempelmeier@gi-de.com>
@m-temp m-temp added the Status:Ready to merge PR is ready to be merged by a committer. label Apr 11, 2024
@vogelpi vogelpi merged commit 0e413fd into lowRISC:master Apr 11, 2024
32 checks passed
@m-temp m-temp deleted the ascon_doc branch April 11, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Ready to merge PR is ready to be merged by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants