Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rv_plic/doc] Add rv_plic dv plan to HW Specification #821

Merged
merged 2 commits into from Nov 4, 2019
Merged

[rv_plic/doc] Add rv_plic dv plan to HW Specification #821

merged 2 commits into from Nov 4, 2019

Conversation

cindychip
Copy link
Contributor

No description provided.

@cindychip cindychip marked this pull request as ready for review November 4, 2019 19:49
msfschaffner
msfschaffner approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@msfschaffner msfschaffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfschaffner
Copy link
Contributor

Oh, one small thing: could you align the arrows in the blockdiagram with the grid? They seem to be slightly off...

eunchan
eunchan approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@eunchan eunchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, it would be better to change the commit title, "Add rv_plic DV Plan link to the `HW Specification section"

@cindychip cindychip changed the title [rv_plic/doc] Add rv_plic to hugo [rv_plic/doc] Add rv_plic dv plan to HW Specification Nov 4, 2019
@cindychip
Copy link
Contributor Author

Thanks Eunchan and Michael, updated!

@cindychip cindychip merged commit 30e427b into lowRISC:master Nov 4, 2019
@cindychip cindychip deleted the add_rv_plic_to_hugo branch November 4, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunchan eunchan eunchan approved these changes

@msfschaffner msfschaffner msfschaffner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cindychip @msfschaffner @eunchan