Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flash_ctrl] Minor clean-up #947

Merged
merged 1 commit into from Nov 11, 2019
Merged

[flash_ctrl] Minor clean-up #947

merged 1 commit into from Nov 11, 2019

Conversation

tjaychen
Copy link

@tjaychen tjaychen commented Nov 8, 2019 •
edited

[flash_ctrl] Minor clean-up
db88f34 
- Removed unnecessary comments
- Address lowRISC#113

Signed-off-by: Timothy Chen <timothytim@google.com>
@tjaychen
Copy link
Author

tjaychen commented Nov 8, 2019

The empty default i think is likely to become a new style guide item..and it just so happens to address #113 as well.

msfschaffner
msfschaffner approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@msfschaffner msfschaffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjaychen tjaychen merged commit 7564e0f into lowRISC:master Nov 11, 2019
@tjaychen tjaychen deleted the flash_warnings branch November 13, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjgitty sjgitty sjgitty approved these changes

@msfschaffner msfschaffner msfschaffner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tjaychen @sjgitty @msfschaffner