Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor.c matches "SEAGATE" for "ASUSTeK" #241

Closed
bp0 opened this issue Mar 20, 2018 · 0 comments · Fixed by #242
Closed

vendor.c matches "SEAGATE" for "ASUSTeK" #241

bp0 opened this issue Mar 20, 2018 · 0 comments · Fixed by #242
Labels
bug

Comments

@bp0
Copy link
Collaborator

bp0 commented Mar 20, 2018

Obviously, a false match.
@bp0 bp0 added the bug label Mar 20, 2018
bp0 added a commit to bp0/hardinfo that referenced this issue Mar 20, 2018
@bp0
vendor.c: try and reduce the likelihood of false matches
98bba17 
* Rename struct memebers to be less ambiguous
* Sort the list by length of match_string so better matches
  match first
* Add flag to force case-sensitve matching so that two or
  three-letter names don't match names that happen to have
  those letters in them

Also, added ASUS and fixes lpereira#241.
(lpereira#241)

Signed-off-by: Burt P <pburt0@gmail.com>
@bp0 bp0 mentioned this issue Mar 20, 2018
Merged
bp0 added a commit to bp0/hardinfo that referenced this issue Mar 20, 2018
@bp0
vendor.c: try and reduce the likelihood of false matches
1eab2e1 
* Rename struct members to be less ambiguous
* Sort the list by length of match_string so better matches
  match first
* Add flag to force case-sensitive matching so that two or
  three-letter names don't match names that happen to have
  those letters in them

Also, added ASUS and fixes lpereira#241.
(lpereira#241)

Signed-off-by: Burt P <pburt0@gmail.com>
bp0 added a commit to bp0/hardinfo that referenced this issue Mar 21, 2018
@bp0
vendor.c: try and reduce the likelihood of false matches
e3bfb1a 
* Rename struct members to be less ambiguous
* Sort the list by length of match_string, longest first,
  so better matches match first
* Add flag to force case-sensitive matching so that two or
  three-letter names don't match names that happen to have
  those letters in them

Also, added ASUS and fixes lpereira#241.
(lpereira#241)

Signed-off-by: Burt P <pburt0@gmail.com>
lpereira pushed a commit that referenced this issue Apr 24, 2018
@bp0 @lpereira
vendor.c: try and reduce the likelihood of false matches
60b9f33 
* Rename struct members to be less ambiguous
* Sort the list by length of match_string, longest first,
  so better matches match first
* Add flag to force case-sensitive matching so that two or
  three-letter names don't match names that happen to have
  those letters in them

Also, added ASUS and fixes #241.
(#241)

Signed-off-by: Burt P <pburt0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vendor.c: try and reduce the likelihood of false matches bp0/hardinfo
1 participant
@bp0