Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "swap" button to the report game popup #32

Closed
mgigol opened this issue Sep 5, 2017 · 2 comments
Closed

Add a "swap" button to the report game popup #32

mgigol opened this issue Sep 5, 2017 · 2 comments

Comments

@mgigol
Copy link

mgigol commented Sep 5, 2017

The button would swap entered players between teams.
It would allow for entering the players before the game is resolved.

@lrem
Copy link
Owner

lrem commented Nov 11, 2017

The design is not what I hoped for (I wanted the swap button to live between the rows, which would work for any number of teams), but should do for what we need now and didn't take rebuilding the whole dialog's code.

@lrem
Copy link
Owner

lrem commented Nov 17, 2017

Just to be clear: the feature is implemented and won't need any more work. It won't deploy right now because there is some breakage in the dependencies. Some got broken in minor releases. Rolling forward fails tests, rolling back passes tests but won't compile a prod build. Go figure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants