Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@pdebuyl review #8

Closed
lrnv opened this issue Nov 12, 2020 · 1 comment
Closed

@pdebuyl review #8

lrnv opened this issue Nov 12, 2020 · 1 comment

Comments

@lrnv
Copy link
Owner

lrnv commented Nov 12, 2020

Some more comments from @pdebuyl:

Typo, page 2, first line. "efficicent" -> "efficient"

Typo, page 2, acknowledgments. "meaningfull" -> "meaningful".

Grammar, page 2, second paragraph. "by statistician" -> "by statisticians" (if you pick singular instead, then conjugation of "need" should be changed as well).

Affiliation: please add "France" to the first affiliation and spell out the second affiliation (+ add city and country).

For specific issues such as the API naming, you can discuss them in cort issues and report the conclusion here. For changes to the paper, I prefer if they are done in this thread.

Originally posted by @pdebuyl in openjournals/joss-reviews#2653 (comment)

@lrnv
Copy link
Owner Author

lrnv commented Nov 12, 2020

Did get merged with the paper issue #15

@lrnv lrnv closed this as completed Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant